Skip to content

Queues == Tehut == APImuncher(Repost to Correct Head_#63

Open
tehut wants to merge 38 commits intoAda-C7:masterfrom
tehut:master
Open

Queues == Tehut == APImuncher(Repost to Correct Head_#63
tehut wants to merge 38 commits intoAda-C7:masterfrom
tehut:master

Conversation

@tehut
Copy link

@tehut tehut commented May 10, 2017

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I played in Postman for a bit but once I got a basic url working I tried to write a bunch of queries from the console
Describe your API Wrapper. How did you decide on the methods you created? I created two instance methods find and all as well as a helper method that cleans up data from the response and saves it in exposed instance variables on the instance of the Edamam object. My .all instance method looks up the query and returns hits, the find method returns recipes and I use my clean method to prepare the uri & from data for the find call.
Describe an edge case or failure case test you wrote for your API Wrapper. I tested to make sure the program would raise a custom error if given bad data or data that returned no search reults
Explain how VCR aids in testing an API. VCR allows us to "replay" a single API call and run all of our tests against it which is important because most APIs have call limits. They tend to be high but if we're running our tests as often as we should we could burn through a lot of API calls
What is the Heroku URL of your deployed application? muncher.herokuapp.com
Do you have any recommendations on how we could improve this project for the next cohort? Nope, I thought this was a challenging project with lots of room to be creative!

tehut added 30 commits May 5, 2017 18:29
@tehut
initial commit--much working
8a9b98e
@tehut
added show page
2da135e
@tehut
added nutrition info to show page
5e6a6ee
@tehut
added error handling to clean method on edamam.rb
e5ed7b5
@tehut
added error handling to clean method on edamam.rb
3313d2b
@tehut
added error handling to clean method on edamam.rb
763f7f3
@tehut
renamed lookup & single lookup methods to .all and .find
cb13d96
@tehut
modified routes to make them RESTful
d4caaa7
@tehut
passed an additional parameter to the .all call in index method
df79953
@tehut
changed views
0eae943
@tehut
added vcr and webmock
b38248d
@tehut
rescued EdamamException for no search results
5205a86
@tehut
replaced flash error handling with Edamam Error
8e1d9c6
@tehut
added data handling for env variables
49561c2
@tehut
display flash message from Edamam rescue
47b65b0
@tehut
added folder for lib test
f0be298
@tehut
vcr testing on api
1b2a510
@tehut
,addressed duplication warning in routes file
3f66ca0
@tehut
fixed parsed response bug I created when fighting VCR tests
560a5dc
@tehut
fixed parsed response bug I created when fighting VCR tests and added…
8b524e5 
… error handling messages
@tehut
refactored hit_array creation code into helper method
f1f6316
@tehut
refactored hit_array creation code into helper method
a7db885
@tehut
set up VCR
e9c89ad
@tehut
vcr cassettes
56a1378
@tehut
added back button to search page
e1d3125
@tehut
refactor
40a96cc
@tehut
styling
61dab58
@tehut
styling
20c5768
@tehut
fixed invalid css
f9208f9
@tehut
fixed invalid css
9a6218d
@droberts-sea
Copy link

droberts-sea commented May 10, 2017

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
General
Rails fundamentals (RESTful routing, use of named paths) yes
Semantic HTML yes
Errors are reported to the user yes - good work
API Wrapper to handle the API requests yes - see inline comments
Controller testing no
Styling
Foundation Styling for responsive layout yes
Search View yes
List View yes
Show View which opens in a new tab yes
API Features
The App attributes Edaman yes
The VCR casettes do not contain the API key yes
Overall

Good work overall! The one thing that's missing is good controller testing. Being able to effectively test a controller is a culmination of all the Rails knowledge and understanding we've worked on so far, and it's a good learning experience. Make sure you practice it on Video Store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tehut @droberts-sea